Add options to change outputFile and filter coverage files - Githubissues

istanbuljs / puppeteer-to-istanbul

given coverage information output by puppeteer's API output a format consumable by Istanbul reports

ISC License

212 stars 46 forks source link

Add options to change outputFile and filter coverage files #25

Closed aadityataparia closed 5 years ago

aadityataparia commented 5 years ago

closes https://github.com/istanbuljs/puppeteer-to-istanbul/issues/15

Adds two options to PuppeteerToIstanbul.prototype.writeIstanbulFormat

Note: This doesn't change default behaviour

Usage

pti.write(coverage, options)

Options

option	Description	Default Value
outputFile	Output coverage will be saved at this file path (can be relative to project root dir or an absolute path)	`./.nyc_output/out.json`
filter	Function to filter coverage files. Coverage will only be saved if it returns `true` for given filePath	`(filePath) => true`

Additional changes

Added tests for lib/puppeteer-to-istanbul.js with 100% coverage 🚀

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 106

7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 104:	0.0%
Covered Lines:	72
Relevant Lines:	72

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 107

7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 104:	0.0%
Covered Lines:	72
Relevant Lines:	72

💛 - Coveralls

ifiokjr commented 5 years ago

Any updates on whether and when this might be merged?

aadityataparia commented 5 years ago

Knock Knock! Someone?