chore(deps): bump v8-to-istanbul from 1.2.1 to 4.1.4

istanbuljs / puppeteer-to-istanbul

given coverage information output by puppeteer's API output a format consumable by Istanbul reports

ISC License

212 stars 46 forks source link

chore(deps): bump v8-to-istanbul from 1.2.1 to 4.1.4 #60

Closed mvegter closed 3 years ago

mvegter commented 4 years ago

Note that this is breaking due to the required load method of the async source-map dependency. Changing the public interface of write to async has its advantages of later upgrading/updating the file system parts to async/promises.

Updated Travis to use the maintenance LTS (node 10 which will be EOL 2021-04-30), see https://nodejs.org/en/about/releases/ for more info.

Fixes #49

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 167

9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 98.917%

Totals
Change from base Build 165:	-0.7%
Covered Lines:	229
Relevant Lines:	229

💛 - Coveralls

skerit commented 4 years ago

Hmm, when I try to use this all my files get 100% covered. It just flags each line as completely covered :/

According to line 147 in v8-to-istanbul's v8-to-istanbul.js file all lines start with a coverage of 1 (a change made in april of 2019, before that the default was 0), and then get set to 0 later. But because puppeteer-to-istanbul only reports the lines that DO get coverage, they're never set to 0?

bcoe commented 4 years ago

@skerit good catch, sounds like we can't merge this just yet. It might be worth coordinating a bit with puppeteer, to see if we can get output that's closer to the raw V8 output?