isteinbrecher / latex2ai

LaTeX Plugin for Adobe Illustrator
MIT License
147 stars 5 forks source link

Update submodule link and import amssymb package #117

Closed dzhi1993 closed 1 year ago

dzhi1993 commented 1 year ago

Thanks for providing this amazing plug-in. This quick fix allows users to build from the source and to support more math symbols in Latex. Please feel free to merge this pull and let me know if there's any problem.

-- dzhi

isteinbrecher commented 1 year ago

Thanks for opening this pull request. The sub-module update makes sense.

Regarding the LaTeX item template, is there a specific reason you want to include amssymb inside the template? LaTeX2AI creates a header file (LaTeX2AI_header.tex) in the document folder. This is the recommended place to put additional packages.

dzhi1993 commented 1 year ago

I see, sorry for importing the package to the wrong place. I added amssymb because I wanted to have \mathbb{} command supported. And I also think it's good to have it as an extended symbol collection if users want to add more latex math symbols that are not predefined. For example, \mathfrak, \triangleq, \approxeq, \rightleftarrows, etc.

Let me know if this makes sense, or feel free to close this pull if it's not necessary. Thanks.

isteinbrecher commented 1 year ago

I opened a separate pull request #118 for the submodule link. I also opened a pull request #119 where the default header is reorganized and the documentation is clarified.

Regarding amssymb, I would like to keep the default used packages as minimal as possible. You can simply add amssymb by adding it to the LaTeX2AI_header.tex file in your document folder (I will try to clean up the Plug-In documentation so this is clearer in the future). Thanks again for your contribution.