search

isteven / angular-multi-select

A multi select dropdown directive for AngularJS. Allows you to use HTML tags and CSS in the data. Requires only AngularJS and nothing else.
isteven.github.io/angular-multi-select
MIT License
1.08k stars 518 forks source link

Filtering problem when grouped #570

Open cschwaderer opened 5 years ago

cschwaderer commented 5 years ago

I've found a problem for filtering/searching multi-level grouped input models, so, I changed the if condition in line 182/183

 if ( typeof $scope.filteredModel[ $scope.filteredModel.length - 1 ][ attrs.groupProperty ] !== 'undefined'
                            && $scope.filteredModel[ $scope.filteredModel.length - 1 ][ attrs.groupProperty ] === false )

into

if (
                            (
                                !$scope.filteredModel[ $scope.filteredModel.length - 1 ]
                                ||
                                typeof $scope.filteredModel[ $scope.filteredModel.length - 1 ][ attrs.groupProperty ] !== 'undefined'
                            )
                            &&
                            (
                                !$scope.filteredModel[ $scope.filteredModel.length - 1 ]
                                ||
                                $scope.filteredModel[ $scope.filteredModel.length - 1 ][ attrs.groupProperty ] === false
                            )

That solved the problem for me. I don't see a point in creating a PR, since it seems they are not eagerly pulled right now anyway. However, feel free the use the fix wherever you want!