Closed AndrewBabbitt97 closed 4 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: AndrewBabbitt97
To complete the pull request process, please assign sawlanipradeep
You can assign the PR to them by writing /assign @sawlanipradeep
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
@googlebot I signed it!
@googlebot I signed it!
Disregard the change, however of note is that it looks like the version of debian your last release was built with has an issue with some ssl certs, found the reason my change worked wasnt the code change but by building the image using a newer version of the debian image.
tlsv12 causes issues with validating certificates on some idP servers with valid ssl certs, upgrading to sslv3 fixes these issues.