istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Upgrade ssl context to sslv3 #100

Closed AndrewBabbitt97 closed 4 years ago

AndrewBabbitt97 commented 4 years ago

tlsv12 causes issues with validating certificates on some idP servers with valid ssl certs, upgrading to sslv3 fixes these issues.

istio-testing commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrewBabbitt97 To complete the pull request process, please assign sawlanipradeep You can assign the PR to them by writing /assign @sawlanipradeep in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

AndrewBabbitt97 commented 4 years ago

@googlebot I signed it!

AndrewBabbitt97 commented 4 years ago

@googlebot I signed it!

AndrewBabbitt97 commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

AndrewBabbitt97 commented 4 years ago

Disregard the change, however of note is that it looks like the version of debian your last release was built with has an issue with some ssl certs, found the reason my change worked wasnt the code change but by building the image using a newer version of the debian image.