search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Update Istio download script to use 1.4.10 #119

Closed cflewis closed 4 years ago

cflewis commented 4 years ago

1.4.0 was causing Envoy crashes following the bookinfo example. Using 1.4.10 prevented the Envoy crashes.

istio-testing commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cflewis To complete the pull request process, please assign liminw You can assign the PR to them by writing /assign @liminw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cflewis commented 4 years ago

/assign @liminw

cflewis commented 4 years ago

P.S. I strongly suggest testing this on your side before merging. It is entirely possible I missed some sort of step when following the doc, but this change appears innocuous given that the minor version remains the same.

cflewis commented 4 years ago

I have changed my mind on this, I actually haven't been able to successfully deploy the example, so I can't be sure it works at all. Sorry for the noise.