search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Fix Run: Unexpected error: !ok #120

Closed AndrewBabbitt97 closed 3 years ago

AndrewBabbitt97 commented 4 years ago

Fixes #112

Not going to go into details here, please reference original issue.

We have been running this change in prod for a while now with no issues.

Only question is if we want to just remove that block of code entirely or leave that logging as is.

istio-testing commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrewBabbitt97 To complete the pull request process, please assign liminw You can assign the PR to them by writing /assign @liminw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AndrewBabbitt97 commented 4 years ago

/assign @liminw

kfud commented 3 years ago

When is this fix going to be released?

AndrewBabbitt97 commented 3 years ago

Not sure if it will at this rate, devs haven't been active on this project at all the past few months. I can see about reaching out to some other Istio devs to see how this projects going to be handled.

kfud commented 3 years ago

I can't even make the project due to vague dependency errors, it's too bad because it's a great authentication proxy.

kfud commented 3 years ago

I can confirm this fix works... auth-service has been running stable for a good week now, where as before it would crash every hour.