Closed stefanhenseler closed 3 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: stefanhenseler
To complete the pull request process, please assign brenodemedeiros after the PR has been reviewed.
You can assign the PR to them by writing /assign @brenodemedeiros
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
I think the EnvoyFilter
should be gradually deprecated, because the CUSTOM action in AuthorizationPolicy
seems to be a less fragile way of doing this: https://istio.io/latest/docs/tasks/security/authorization/authz-custom/
Have you tried it out with AuthService?
This is done. Please check the book-info/readme.md now. thanks!
Fixes issue #122. Seems like the typed config makes the filter work again with istio 1.7.x. I've used the example here: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/ext_authz_filter