Fixes envoy filter to work with istio 1.7.4

stefanhenseler commented 3 years ago

Fixes issue #122. Seems like the typed config makes the filter work again with istio 1.7.x. I've used the example here: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/ext_authz_filter

istio-testing commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stefanhenseler To complete the pull request process, please assign brenodemedeiros after the PR has been reviewed. You can assign the PR to them by writing /assign @brenodemedeiros in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

stefanhenseler commented 3 years ago

@googlebot I signed it!

ipuustin commented 3 years ago

I think the EnvoyFilter should be gradually deprecated, because the CUSTOM action in AuthorizationPolicy seems to be a less fragile way of doing this: https://istio.io/latest/docs/tasks/security/authorization/authz-custom/

Have you tried it out with AuthService?

incfly commented 3 years ago

This is done. Please check the book-info/readme.md now. thanks!

istio-ecosystem / authservice