search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Add global filter chain configuration API part 2 #136

Closed Shikugawa closed 3 years ago

Shikugawa commented 3 years ago

Close #132

Shikugawa commented 3 years ago

cc: @ZackButcher @lizan

ZackButcher commented 3 years ago

Can you update https://github.com/istio-ecosystem/authservice/blob/master/docs/README.md (which looks generated, but I haven't looked into how yet), and add an example using the override somewhere so it's easy for someone to see how to use it?

cfryanr commented 3 years ago

Can you update https://github.com/istio-ecosystem/authservice/blob/master/docs/README.md (which looks generated, but I haven't looked into how yet), and add an example using the override somewhere so it's easy for someone to see how to use it?

In case it helps, you can regenerate the docs with make docs and then commit the updated doc. See Makefile.

istio-testing commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizan, Shikugawa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)~~ [lizan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment