search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Introduce Lazy OIDCConfig validation #137

Closed Shikugawa closed 3 years ago

Shikugawa commented 3 years ago

In the current implementation, default_oidc_config and oidc_override will be validated before starting the server, it results in users can't configure them without stripping redundant information, they can't be DRY.

In this patch, we fix this problem by delaying config evaluation after all of fragmented config will be merged.

Shikugawa commented 3 years ago

@lizan PTAL

istio-testing commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizan, Shikugawa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)~~ [lizan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment