Closed ipuustin closed 3 years ago
@Shikugawa: changing LGTM is restricted to collaborators
@Shikugawa thanks for the review! I implemented the changes you requested.
@ipuustin LGTM. Could you rewrite PR title and description into Add a new filter type: "mock"
?
/approve
ping @lizan
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ipuustin, lizan, Shikugawa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Add a "mock" filter type. The filter approves or denies requests based on configuration value. The benefit of this is twofold:
Also, this helps to keep the filter abstraction in working shape by preventing configuration validation etc. getting tied to OIDC.