search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

fix to treat IDToken header as case-insensitive #144

Closed Shikugawa closed 3 years ago

Shikugawa commented 3 years ago

Close #141

In this PR, we fix the previous behavior which treat specified ID token header as case-sensitive. It is not required behavior and if we set Authorization as this. We will skip token check because ext_authz passes lower cased HTTP header value.

istio-testing commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizan, Shikugawa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)~~ [lizan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment