search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Adding working examples for istio-1.10.3 #145

Closed anhdle14 closed 3 years ago

anhdle14 commented 3 years ago

This PR is not ready yet, but provide the first draft for updating the documentation to the latest version of Istio.

istio-testing commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anhdle14 To complete the pull request process, please assign icygalz after the PR has been reviewed. You can assign the PR to them by writing /assign @icygalz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
anhdle14 commented 3 years ago

Thank you for the suggestion. I will make some new changes.

One thing I would like to clarify is the example for auth-service in gateway. I try to adopt the logic to the gateway as well but doesn't work. The site will only get RBAC: access denied message. If possible I would like to update README.md for that or write a proper example for it.

istio-testing commented 3 years ago

@anhdle14: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
anhdle14 commented 3 years ago

Close in favor of #148