search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Update a few issues w.r.t jwk update and listeners. #153

Closed incfly closed 3 years ago

incfly commented 3 years ago

Since 1.10 Istio no longer support app listening on port localhost. Also update the doc of how to set up jwk, which could be updated.

Fix #149

Signed-off-by: Jianfei Hu jianfeih@tetrate.io Signed-off-by: Jianfei Hu jianfeih@google.com

incfly commented 3 years ago

tried to plumb through helm values for the jwk content a bit. not work well since it has some string escape issues (when using --set from helm cli, the escaped value is unescaped...)

suboptimial but at least offer a way. we won't need this once jwkURI fectching is supported..

istio-testing commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incfly, lizan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)~~ [incfly,lizan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment