Closed Shikugawa closed 3 years ago
Are you suggesting that we can add this grpc_health_probe
binary into the authservice docker image, and then configure with command type health check? https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-liveness-command
In comparision, adding a HTTP REST point does not require adding new dependencies into our docker images(consider the CVEs the burden to update the binary), and semantics (response code, headers, timeout, etc) is wider understood.
because of the above, I would prefer to have HTTP instead then.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incfly, Shikugawa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Some test seems has failed.
Oops, I didn't realize that the bot would merge the PR when there's a test failure. @Shikugawa could you take a look and send a fix? https://github.com/istio-ecosystem/authservice/runs/3972302821?check_suite_focus=true
It is because we don't have to add rest endpoint only for healthcheck. We can utilize grpc-health-probe here. https://github.com/grpc-ecosystem/grpc-health-probe