Closed dio closed 2 years ago
Sample of running this on CI: https://github.com/3128px/authservice/pull/1.
/assign @liminw
/approve
@incfly @Shikugawa Sorry, what is "Pending — Not mergeable. Needs lgtm label."? Do I need to do something else? 🙂
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dio, incfly, Shikugawa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
One small thing, there seems some issue about the bazel output char encoding. In my browser, searching for 2022-02-04T13:10:26.1470736Z 0/0/0/1/4
in the CI test log, you will see many characters are marked as ?
.
https://github.com/istio-ecosystem/authservice/runs/5066489064?check_suite_focus=true, ubuntu 20-04.
I checked another PR's test this is fine, https://github.com/istio-ecosystem/authservice/pull/204,
This patch makes sure we can build on macOS (while limited for amd64 for now).
Several changes in this patch:
BUILD
toBUILD.bazel
due to case-insensitivity of (the default) macOS filesystem.github.com/nelhage/rules_boost
to manage boost dependencies.bazel
throughbazelisk
..bazelversion
to4.2.2
(still can't update to5.0.0
yet).bazel
files withbuildifier
. (Sorry for the formatting noise! I need that since I was trying to fix #176), and wanting to be sure it is lint-ed.Notes to the reviewer: I can try to clean up the Makefile more and streamline the management of
clang
(includingclang-format
), and other required toolings: if that makes sense of sending that kind of PR(s).Signed-off-by: Dhi Aurrahman dio@rockybars.com