search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Fix github access token naming. #217

Closed incfly closed 2 years ago

incfly commented 2 years ago

Signed-off-by: Jianfei Hu hujianfei258@gmail.com

incfly commented 2 years ago

@dio

istio-testing commented 2 years ago

@dio: changing LGTM is restricted to collaborators

In response to [this](https://github.com/istio-ecosystem/authservice/pull/217#pullrequestreview-926863825): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
istio-testing commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dio, incfly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)~~ [incfly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dio commented 2 years ago

The CI issue seems a timeout one, probably we can restart the build?

incfly commented 2 years ago

yeah, I restarted the failed one, seems working now.