search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Move the VERSION env to GITHUB_ENV. #221

Closed incfly closed 2 years ago

incfly commented 2 years ago

Signed-off-by: Jianfei Hu hujianfei258@gmail.com

As suggested by @dio https://github.com/istio-ecosystem/authservice/commit/28404a8f3f9e11ff14e81d6650ffc72245355653#commitcomment-70845200

incfly commented 2 years ago

@dio

incfly commented 2 years ago

and yeah i noticed that the image tag we generate are actually suffix with some hexical string.. instead of 0.5.1

istio-testing commented 2 years ago

@dio: changing LGTM is restricted to collaborators

In response to [this](https://github.com/istio-ecosystem/authservice/pull/221#pullrequestreview-938776994): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
istio-testing commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dio, incfly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)~~ [incfly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment