search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Update protoc-gen-go comment to fix `make check` #257

Closed sergicastro closed 5 months ago

sergicastro commented 5 months ago

When we update the proto-gen-go dependency we should be running make generate to update the version comment in the generated .pb.go files.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@f2ef0e4). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #257 +/- ## ======================================= Coverage ? 90.64% ======================================= Files ? 25 Lines ? 1603 Branches ? 0 ======================================= Hits ? 1453 Misses ? 107 Partials ? 43 ```
sergicastro commented 5 months ago

Good point, version pinned!