istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
220 stars 62 forks source link

Hide OIDC client secret from INFO logs #268

Open SemiCicada opened 5 days ago

SemiCicada commented 5 days ago

I am using Authservice v1.0.3.

When adding OIDC client secrets from a Kubernetes secret, they are shown in the pod logs at log_level="info" as an array of integers. Perhaps it's better to have it at the "debug" or "trace" level instead? Or alternatively the message stays but the secret value is kept hidden.

https://github.com/istio-ecosystem/authservice/blob/adea4ec0bdc9cd756622a6f0234473100be4a377/internal/k8s/secret_controller.go#L220-L222