search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

13 select token #42

Closed nickrmc83 closed 5 years ago

nickrmc83 commented 5 years ago

fixes #13

istio-testing commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickrmc83 To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nickrmc83 commented 5 years ago

@cfryanr @peterhaochen47 @tylerschultz see changes here. They can't be merged until the Envoy multi-cookie fixes but apart from that this should be good to go pending review.

googlebot commented 5 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

peterhaochen47 commented 5 years ago

@googlebot I consent

Also I think @nickrmc83 (the PR submitter) needs to approve our commit in order to make CLA pass/

nickrmc83 commented 5 years ago

@cfryanr I've introduced https://github.com/envoyproxy/protoc-gen-validate to allow config fields to be decorated with validation rules. This means we can drop the manual verification code and also generate documentation on allowable values.

nickrmc83 commented 5 years ago

@cfryanr can you add a lgtm comment if you're now happy with all the changes in this PR?

fixes #41

peterhaochen47 commented 5 years ago

/lgtm

peterhaochen47 commented 5 years ago

Also I think @nickrmc83 (the PR submitter) needs to approve our commit in order to make CLA pass: https://github.com/istio-ecosystem/authservice/pull/42#issuecomment-543996134

nickrmc83 commented 5 years ago

@googlebot I consent

nickrmc83 commented 5 years ago

@cfryanr I think you need to add a consent comment too.

cfryanr commented 5 years ago

@googlebot I consent

Changdrew commented 5 years ago

@googlebot I consent

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.