Closed neilong31 closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: neilong31, nickrmc83
To complete the pull request process, please assign
You can assign the PR to them by writing /assign
in a comment when ready.
The full list of commands accepted by this bot can be found here.
@neilong31 The changes look good and thanks for the PR. You need to sign-off your commit and make sure you have a valid google CLA (see failure details links). Once you've fixed those issues I'll merge.
Thanks! I have signed-off on my commit and filled out my google CLA.
/lgtm
Fixes #45 Any time I saw transparent_auth as a header, namespace, or in the comments I changed it to authservice in both the src and test folders. I also followed the same coding conventions.