33 fix todos - Githubissues

nickrmc83 commented 5 years ago

Fixing most of the necessary TODOs.

Fixes validation of nonce and aud JWT fields at token acquisition time.
Added Max-Age attributes to cookies.
Removed invalid or won't-do TODOs.

fixes #33

Any remaining TODOs can be done at a later date or will be fixed by other issues.

nickrmc83 commented 5 years ago

@cfryanr @tylerschultz I think this is now good to go assuming you're happy with the changes.

cfryanr commented 4 years ago

/lgtm

cfryanr commented 4 years ago

/approve

istio-testing commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cfryanr, nickrmc83 To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

istio-ecosystem / authservice

33 fix todos #47