istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Configure all uris as strings instead of URI parts #75

Closed andrewedstrom closed 4 years ago

andrewedstrom commented 4 years ago

Resolves #60

istio-testing commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewedstrom To complete the pull request process, please assign liminw You can assign the PR to them by writing /assign @liminw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

peterhaochen47 commented 4 years ago

@googlebot I fixed it.

andrewedstrom commented 4 years ago

@googlebot I fixed it.

peterhaochen47 commented 4 years ago

@googlebot I fixed it.

peterhaochen47 commented 4 years ago

@googlebot I fixed it.

peterhaochen47 commented 4 years ago

@googlebot I fixed it.

peterhaochen47 commented 4 years ago

Closing this PR due to CLA issue, replaced by PR #77