istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Issue60 config uris as strings 2 #77

Closed peterhaochen47 closed 4 years ago

peterhaochen47 commented 4 years ago

Fixes #60

istio-testing commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: peterhaochen47 To complete the pull request process, please assign icygalz You can assign the PR to them by writing /assign @icygalz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/istio-ecosystem/authservice/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
peterhaochen47 commented 4 years ago

/lgtm

istio-testing commented 4 years ago

@peterhaochen47: you cannot LGTM your own PR.

In response to [this](https://github.com/istio-ecosystem/authservice/pull/77#issuecomment-598418996): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.