search

istio-ecosystem / authservice

Move OIDC token acquisition out of your app code and into the Istio mesh
Apache License 2.0
217 stars 63 forks source link

Suggested doc improvements #83

Open cfryanr opened 4 years ago

cfryanr commented 4 years ago

On Istio Slack:

From Shriram Rajagopalan (Tetrate):

Can you convert the readme into an Istio doc example or something? This is quite useful. You can document it so that more people have access to it Take this https://github.com/istio-ecosystem/authservice/tree/master/bookinfo-example#authz-with-review-service-optional and make this change part of official bookinfo so that you wont have to build your own.

As suggested above, we could PR the change to Istio's https://github.com/istio/istio/blob/master/samples/bookinfo/src/productpage/productpage.py#L185 file (fixing incoming_headers to allow the authorization header to be forwarded on backend app requests).

Second, migrate all your stuff to use new authN api https://github.com/istio-ecosystem/authservice/blob/master/bookinfo-example/config/bookinfo-authn-policy-template-adding-reviews.yaml specificallty