search

istio-ecosystem / istio-ingress-migrate

A tool to convert legacy Istio (1.5 and lower) Ingress+Gateway configurations to standardized Ingress configurations.
0 stars 0 forks source link

Add Explainer in the README of conversion with examples #1

Open mandarjog opened 3 years ago

mandarjog commented 3 years ago

When the tool is unable to convert from 1.4 to k8sIngress we emit an error message. When there is an error, the user needs to understand what the tool is trying to do at the next level of details.

  1. Add an explainer of how the conversion should work.
  2. Add examples, including examples from test cases.
howardjohn commented 3 years ago

The README now has a catalog of all errors with explanations. PTAL

mandarjog commented 3 years ago

Thanks John.

  1. What is the behaviour for hostConflict in gateway in 1.4? We should point that out as part of the error message.

  2. error5 if ingress tls is being ignored then we should use 1.4 gw tls settings to create 1.6 ingress. I think emitting an info message is ok, but the xform will not change behaviour.

  3. What is the current behaviour with error6 ?

howardjohn commented 3 years ago

What is the behaviour for hostConflict in gateway in 1.4? We should point that out as part of the error message.

Behavior undefined, I think it will pick an arbitrary one (probably sorted by age?)

error5 if ingress tls is being ignored then we should use 1.4 gw tls settings to create 1.6 ingress. I think emitting an info message is ok, but the xform will not change behaviour.

This is the behavior, we use the GW settings (because it is what is used in practice) but we warn since we are overriding their TLS settings

What is the current behaviour with error6?

Istio allows SNI and Host to be distinct. You technically could have gw for foo.com and Ingress for bar.com, although its probably a bad idea