istio-ecosystem / sail-operator

The Sail Operator is able to install and manage the lifecycle of the Istio control plane in an Kubernetes & OpenShift cluster.
Apache License 2.0
42 stars 28 forks source link

Clarify discovery selector scoping terminology #448

Closed longmuir closed 1 month ago

longmuir commented 1 month ago

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

istio-testing commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
linux-foundation-easycla[bot] commented 1 month ago

CLA Missing ID CLA Not Signed

istio-testing commented 1 month ago

@longmuir: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests-arm64_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test unit-tests-arm64
integ-tests-arm64_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test integ-tests-arm64
gencheck_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test gencheck
e2e-kind_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test e2e-kind
integ-tests_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test integ-tests
e2e-kind-dualstack_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test e2e-kind-dualstack
e2e-kind-multicluster_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test e2e-kind-multicluster
lint_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test lint
scorecard_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test scorecard
e2e-kind-olm_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test e2e-kind-olm
unit-tests_sail-operator_main 7924f25b036fd4630b5edb977a2489ee8592438c link true /test unit-tests
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).