search

istio-ecosystem / sail-operator

The Sail Operator is able to install and manage the lifecycle of the Istio control plane in an Kubernetes & OpenShift cluster.
Apache License 2.0
42 stars 28 forks source link

Set global.platform when not set by the user #451

Closed luksa closed 4 weeks ago

luksa commented 1 month ago

This change ensures that the openshift platform is set correctly even when the openshift profile isn't selected via spec.profile.

Users can now select a profile (e.g. remote) and still have the correct platform selected automatically.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 75.80%. Comparing base (16c3e03) to head (b51f575). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/istiovalues/profiles.go 50.00% 3 Missing and 1 partial :warning:
cmd/main.go 0.00% 3 Missing :warning:
pkg/helm/values.go 62.50% 2 Missing and 1 partial :warning:
controllers/remoteistio/remoteistio_controller.go 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #451 +/- ## ========================================== + Coverage 75.73% 75.80% +0.06% ========================================== Files 35 35 Lines 2061 2079 +18 ========================================== + Hits 1561 1576 +15 - Misses 428 430 +2 - Partials 72 73 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.