search

istio-ecosystem / sail-operator

The Sail Operator is able to install and manage the lifecycle of the Istio control plane in an Kubernetes & OpenShift cluster.
Apache License 2.0
42 stars 28 forks source link

Consolidate reconciler config fields into ReconcilerConfig #453

Closed luksa closed 4 weeks ago

luksa commented 4 weeks ago

Most reconcilers need the same three config fields: ResourceDirectory, Platform, and DefaultProfile. Instead of passing these fields separately, we now pass them via a ReconcilerConfig struct.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 63.88889% with 13 lines in your changes missing coverage. Please review.

Project coverage is 75.54%. Comparing base (1ac8e14) to head (2e70cd1). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/main.go 0.00% 11 Missing :warning:
controllers/remoteistio/remoteistio_controller.go 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #453 +/- ## ========================================== - Coverage 75.61% 75.54% -0.08% ========================================== Files 35 35 Lines 2079 2073 -6 ========================================== - Hits 1572 1566 -6 Misses 433 433 Partials 74 74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.