istio-ecosystem / sail-operator

The Sail Operator is able to install and manage the lifecycle of the Istio control plane in an Kubernetes & OpenShift cluster.
Apache License 2.0
41 stars 28 forks source link

[FEATURE] Avoid the use of bookinfo as testing app or enable a way to set custom images #467

Closed fjglira closed 16 hours ago

fjglira commented 2 weeks ago

Is this the right place to submit this?

Feature Description

We can test the configuration in the e2e framework by using an alternative containers or adding the possibility to set custom images that can be set by the user to avoid pulling always upstream images to run the test

Additional Information

No response

fjglira commented 2 weeks ago

Checking the code we use bookinfo app only to validate istio injection, we can change this and use any other app that can allow us to check this and also that can work later as tooling app to validate connection when we is needed, in multicluster test we use sample and sleep app. @FilipB I think I can set a way to set a custom image for those containers and continuing using sleep pod or sample app because we will need this types of apps to validate connectivity in diferents scenarios later. WDYT?

FilipB commented 1 week ago

I don't know if we will need to use the sleep app for e2e operator tests in the future. If yes, let's use it. If no, we could test the injection just using a standalone ingress

fjglira commented 1 week ago

I'll work on this next week. Folks from IBM needed to be able to set their own images, this will leave to the user the possibility to set their own container image for the test run