search

istio-ecosystem / wasm-extensions

Contains miscellaneous Wasm extensions for Istio
Apache License 2.0
107 stars 34 forks source link

Update basic auth filter to consume base64 encoded password #11

Open bianpengyuan opened 3 years ago

bianpengyuan commented 3 years ago

Currently basic auth filter only consumes plain text username:passwd. This is to track the work to make it read base64 encoded username:passwd instead.

mboveri commented 3 years ago

Would this also add functionality to allow the basic auth filter to be able to consume from a Kubernetes secret or environment variable generated by a Kubernetes secret?

bianpengyuan commented 3 years ago

Yeah it depends on this: https://github.com/proxy-wasm/proxy-wasm-cpp-host/issues/127

bianpengyuan commented 3 years ago

And envoy just added support for Wasm env variable read: https://github.com/envoyproxy/envoy/issues/14958 I can add some support based on that.

mboveri commented 3 years ago

That would be great!

johnzheng1975 commented 1 year ago

And envoy just added support for Wasm env variable read: envoyproxy/envoy#14958 I can add some support based on that.

@bianpengyuan , had istio supported this -- wasm can read env variable from istio-proxy now? Can you provide some example. Thanks.