istio-ecosystem / wasm-extensions

Contains miscellaneous Wasm extensions for Istio
Apache License 2.0
107 stars 34 forks source link

Add Local Rate Limit Filter #20

Closed gargnupur closed 3 years ago

gargnupur commented 3 years ago

This is still work-in-progress.. will ping when it's ready for review.

bianpengyuan commented 3 years ago

I think we'd want something much simpler, probably just the following:

message LocalRateLimitConfig {
  message QuotaConfig {
    google.protobuf.duration interval = 1;
    int max_requests = 2;
  }
  repeated QuotaConfig quota_configs = 1;
}

Instead of rich configurability, user should just customize the plugin. wdyt? @mandarjog @kyessenov