search

istio-ecosystem / wasm-extensions

Contains miscellaneous Wasm extensions for Istio
Apache License 2.0
105 stars 34 forks source link

Build and push Wasm OCI images. #71

Closed mathetake closed 2 years ago

mathetake commented 2 years ago

resolves #69

mathetake commented 2 years ago 
2021/11/18 01:37:53 Error pushing image to ghcr.io/istio-ecosystem/wasm-extensions/scaffold:b5277dc782948d1d573ea076dc4acc6523aaa7a7: unable to push image to ghcr.io/istio-ecosystem/wasm-extensions/scaffold:b5277dc782948d1d573ea076dc4acc6523aaa7a7: POST https://ghcr.io/v2/istio-ecosystem/wasm-extensions/scaffold/blobs/uploads/: DENIED: permission_denied: create_package

@bianpengyuan can you make sure that the credential has the ^^ create_package permission ?

bianpengyuan commented 2 years ago

@mathetake yeah I did. Tested locally and I don't have permission to write package either. Looks like the package write permission is org scoped? @linsun could you grant me and/or @mathetake permission to create/delete packages at istio-ecosystem org?

linsun commented 2 years ago

@bianpengyuan you are already an admin in the wasm-extensions repo. I also made @mathetake the admin as well.

mathetake commented 2 years ago 
2021/11/23 23:48:25 Successfully pushed OCI image to ghcr.io/istio-ecosystem/wasm-extensions/basic_auth:b5277dc782948d1d573ea076dc4acc6523aaa7a7

now succeeded to push images, but I don't have permission to make the registries visible in (seems I need to have org-wide pkg related permissions) https://github.com/orgs/istio-ecosystem/packages

bianpengyuan commented 2 years ago

Yeah after I join the org, my token is able to push packages now. Looks like to make these image public, what we need to do is at org level Settings > Packages, tick the Public. After that I should be able to make these images public visible. Then we can turn it back to Private only. I will coordinate with @linsun offline on this.

mathetake commented 2 years ago

I think you can configure the visibility at registries level on "Package settings" in a package view. For example, the bottom right in this screen shot: Screen Shot 2021-11-24 at 10 11 49

bianpengyuan commented 2 years ago

@mathetak Yeah but currently it cannot be done and I think we need to change the org level package setting to allow public package?

Screen Shot 2021-11-23 at 5 16 54 PM

e

mathetake commented 2 years ago

oh I see! Thanks!

bianpengyuan commented 2 years ago

All packages are public now.