istio-ecosystem / wasm-extensions

Contains miscellaneous Wasm extensions for Istio
Apache License 2.0
105 stars 34 forks source link

Add wasm-oidc-plugin #93

Open antonengelhardt opened 5 months ago

antonengelhardt commented 5 months ago

Hey there,

i figured it might be useful to include https://github.com/antonengelhardt/wasm-oidc-plugin/ inside this repo. Or are only Wasm Extension written in C++ featured?

Cheers

kyessenov commented 5 months ago

No, it's any language, as long as it can be built and tested in CI.

antonengelhardt commented 5 months ago

@kyessenov Ok, thanks.

Should i open a PR? And how do you want it to be integrated?

kyessenov commented 5 months ago

Yes, you can open a PR. You might need to add a CI step for rust filters specifically, since the base probably doesn't have rust already.

antonengelhardt commented 5 months ago

@kyessenov Ok. Does it make sense to add it as a submodule? I have not worked with that before but maybe this makes updating it easier?

kyessenov commented 5 months ago

It's easier with a copy I think. If you just want a mention on the docs there, we're happy to link to your repo.

antonengelhardt commented 5 months ago

What do you think? https://github.com/istio-ecosystem/wasm-extensions/pull/95