search

istio / api

API definitions for the Istio project
Apache License 2.0
455 stars 550 forks source link

Show the latest API Version in Examples #3192

Closed whitneygriffith closed 4 months ago

whitneygriffith commented 4 months ago

Part of #3127 Resolves istio.io/14992

Depends on tools/2921 Builds on #3188, I will rebase once its merged

istio-testing commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

whitneygriffith commented 4 months ago

I noticed in the protos there are aliases based on the version. For example, // $aliases: [/docs/reference/config/networking/v1alpha3/destination-rule]. How is this used? Should we remove or update this?

whitneygriffith commented 4 months ago

@ericvn PTAL

ericvn commented 4 months ago

I noticed in the protos there are aliases based on the version. For example, // $aliases: [/docs/reference/config/networking/v1alpha3/destination-rule]. How is this used? Should we remove or update this?

If I understand your question, this is simply telling Hugo that there is another address that can point to this page (it's typically used when moving or renaming a page). ie, /docs/reference/config/networking/v1alpha3/destination-rule and /docs/reference/config/networking/v1beta1/destination-rulecould be resolved and point to a/docs/reference/config/networking/v1/destination-rule` page.

istio-testing commented 4 months ago

In response to a cherrypick label: new pull request created: #3207