search

istio / api

API definitions for the Istio project
Apache License 2.0
455 stars 550 forks source link

[release-1.22] Fix typo in closing tag for some code blocks #3213

Closed istio-testing closed 4 months ago

istio-testing commented 4 months ago

This is an automated cherry-pick of #3196

linux-foundation-easycla[bot] commented 4 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

zirain commented 4 months ago

not sure why CLA fails.

craigbox commented 4 months ago

/retest

istio-testing commented 4 months ago

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gencheck_api_release-1.22 424df7f92e336292f72525ebb37a7397ae3d7fc4 link true /test gencheck
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kimsondrup commented 4 months ago

not sure why CLA fails.

¯\_(ツ)_/¯ it works now, all good 👍

zirain commented 4 months ago

not sure why CLA fails.

¯_(ツ)_/¯ it works now, all good 👍

can you do a manual cherrypick to fix gencheck?

kimsondrup commented 4 months ago

Created #3214 to fix gencheck. Just need a trusted user to comment /ok-to-test 🙏

zirain commented 4 months ago

replaced by https://github.com/istio/api/pull/3214