istio / enhancements

Enhancement Tracking and Backlog Repo for Istio Releases
14 stars 42 forks source link

promote authz dry-run to alpha #112

Closed yangminzhu closed 2 years ago

yangminzhu commented 2 years ago

@istio/technical-oversight-committee could someone help take a look the PR? thanks.

louiscryan commented 2 years ago

Is the user-feedback on the feature captured somewhere ?

yangminzhu commented 2 years ago

Is the user-feedback on the feature captured somewhere ?

@louiscryan

I think we do not have much written feedback on this feature. We do have some customers asking questions like "how to roll out authorization policies in WARN mode before enforcing" in the slack channel and we pointed them to the dry-run task (https://preliminary.istio.io/latest/docs/tasks/security/authorization/authz-dry-run/) which they later confirmed it is exactly what they are looking for.

louiscryan commented 2 years ago

I'm fine with progressing the feature. Get one other TOC member?

On Fri, Dec 10, 2021 at 5:01 PM Yangmin Zhu @.***> wrote:

Is the user-feedback on the feature captured somewhere ?

@louiscryan https://github.com/louiscryan

I think we do not have much written feedback on this feature. We do have some customers asking questions like "how to roll out authorization policies in WARN mode before enforcing" in the slack channel and we pointed them to the dry-run task ( https://preliminary.istio.io/latest/docs/tasks/security/authorization/authz-dry-run/) which they later confirmed it is exactly what they are looking for.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/istio/enhancements/pull/112#issuecomment-991397819, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACFAUPBXU46MTFC4CAFWR6LUQKPG3ANCNFSM5JK2VTAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

smawson commented 2 years ago

I'm fine with this progressing as well, do we need a TOC discussion or just approve it here? I do see some items still waiting on PRs to be submitted though so those should go in and be updated here.

howardjohn commented 2 years ago

+1 from me as well

nrjpoddar commented 2 years ago

LGTM

Xunzhuo commented 2 years ago

LGTM from me too.

yangminzhu commented 2 years ago

@louiscryan @smawson @howardjohn @howardjohn Thanks for the review!

I have updated the PR for the remaining items, the other API PR has been merged and I have also sent the release note PR (https://github.com/istio/istio/pull/36581), Please feel free to approve or let me know if you have other questions.

yangminzhu commented 2 years ago

@louiscryan @smawson @howardjohn @howardjohn could you approve the PR now? Thanks.

nrjpoddar commented 2 years ago

LGTM