search

istio / enhancements

Enhancement Tracking and Backlog Repo for Istio Releases
14 stars 42 forks source link

Promote Canary Upgrade and Revision Tags to Beta #136

Closed kfaseela closed 1 year ago

kfaseela commented 1 year ago

Signed-off-by: Faseela K faseela.k@est.tech

howardjohn commented 1 year ago

Oops, thought this was supposed to have 2 approvals before merge. I guess not. fyi @istio/technical-oversight-committee if anyone has concerns

ericvn commented 1 year ago

Looks good to me as well.

kfaseela commented 1 year ago

/cherrypick release-1.17

istio-testing commented 1 year ago

@kfaseela: new pull request created: #137

In response to [this](https://github.com/istio/enhancements/pull/136#issuecomment-1406582019): >/cherrypick release-1.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
linsun commented 1 year ago

@kfaseela thanks for pushing this!! My only concern is the doc is not tested: https://istio.io/latest/docs/setup/upgrade/canary/

IIRC, we require all beta feature to be tested in our docs.

kfaseela commented 1 year ago

@kfaseela thanks for pushing this!! My only concern is the doc is not tested: https://istio.io/latest/docs/setup/upgrade/canary/

IIRC, we require all beta feature to be tested in our docs.

Hello @linsun : As part of the promotion, doc tests were added. please see https://preliminary.istio.io/latest/docs/setup/upgrade/canary/

linsun commented 1 year ago

Very nice @kfaseela!