search

istio / enhancements

Enhancement Tracking and Backlog Repo for Istio Releases
14 stars 42 forks source link

Fix broken link to external-controlplane doc #67

Closed frankbu closed 3 years ago

brian-avery commented 3 years ago

This is related to changes made in https://github.com/istio/istio.io/pull/9727/files.

ericvn commented 3 years ago

/cherry-pick release-1.10

istio-testing commented 3 years ago

@ericvn: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to [this](https://github.com/istio/enhancements/pull/67#issuecomment-840105558): >/cherry-pick release-1.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ericvn commented 3 years ago

@linsun @dcberg @louiscryan @smawson @duderino @nrjpoddar - Sorry to explicitly put you here, but we need this PR and it's cherry-pick for release-1.10, once it's created after this PR merges, to be merge, so that the reference updates for istio.io can happen. Without this change, the linter of the istio.io PR pulling in reference updates fails as the link is wrong.

istio-testing commented 3 years ago

@ericvn: new pull request created: #68

In response to [this](https://github.com/istio/enhancements/pull/67#issuecomment-840105558): >/cherry-pick release-1.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.