frankbu
commented
2 years ago These are the docs that have no cleanup instructions at all:
content/en/docs//tasks/observability/metrics/customize-metrics/index.md
content/en/docs//tasks/traffic-management/ingress/gateway-api/index.md
content/en/docs//setup/additional-setup/cni/index.md
content/en/docs//setup/additional-setup/gateway/index.md
content/en/docs/setup/install/multicluster/
content/en/docs//examples/virtual-machines/index.md
content/en/docs/ops/configuration/mesh/config-resource-ready/index.md
content/en/docs/ops/configuration/security/security-policy-examples/index.md
content/en/docs/ops/configuration/telemetry/envoy-stats/index.md
content/en/docs//ops/configuration/traffic-management/network-topologies/index.md
content/en/docs/ops/diagnostic-tools/istioctl-analyze/index.mdSome are ops docs, which might be OK.
johnma14
jaellio
The cleanup instructions in various docs are missing. Some docs do complete uninstall, some do partial, and some have no cleanup instructions at all. The ones that have partial or no instructions have cleanup commands in the test.sh (but many of those are only partially correct, just enough to pass the before/after snapshot diff).
We need do a pass through all of the docs to make sure they include proper cleanup instructions and then cleanup the tests to call the cleanup snips instead coding the cleanup commands themselves.