istio / istio.io

Source for the istio.io site
https://istio.io/
Apache License 2.0
761 stars 1.54k forks source link

added destinationrules yaml applying #15706

Open Eseeldur opened 1 month ago

Eseeldur commented 1 month ago

Maybe I am wrong, but shouldn't the instruction include the applying DestinationRules files? I am new at istio and just get started. My minikube cluster doesn't work without applying it. If i not apply DestinationRules, it shows errors on review zone on web page on browser.

Description

Reviewers

istio-policy-bot commented 1 month ago

😊 Welcome! This is either your first contribution to the Istio documentation repo, or it's been a while since you've been here. A few things you should know:

Thanks for contributing!

Courtesy of your friendly welcome wagon.

linux-foundation-easycla[bot] commented 1 month ago

CLA Signed


The committers listed above are authorized under a signed CLA.

istio-testing commented 1 month ago

Hi @Eseeldur. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
istio-testing commented 1 month ago

@Eseeldur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gencheck_istio.io_release-1.23 36d3922a6c4f5d1e91a1e028fe0dc89e2199374a link true /test gencheck
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).