search

istio / istio

Connect, secure, control, and observe services.
https://istio.io
Apache License 2.0
35.9k stars 7.75k forks source link

How to handle Isito chart version #8895

Closed gyliu513 closed 6 years ago

gyliu513 commented 6 years ago

Istio 1.0 already got released, but we are continually fixing bugs in release-1.0 branch for Istio helm chart without updating the helm chart version.

This may bring some trouble to end user, as they may confused sometimes Istio 1.0 helm chart have different configurations.

For Helm chart policy, the update to a released helm chart should have the chart version increased, we already have those field in helm chart, shall we follow the guidance to increase the version field for each backed merge to release-1.0 branch?

version: 1.1.0
appVersion: 1.1.0

/cc @costinm @sdake @linsun @morvencao

linsun commented 6 years ago

I think this is reasonable going forward for fixpacks and LTSs. I would not worry about it for monthly releases.

sdake commented 6 years ago

@gyliu513 in speaking with @hklai about this topic, T&R plans to automate the version field changes for istio-1.0.3 and later.

Cheers -steve

hklai commented 6 years ago

I originally plan to update these versions similar to how we deal with the tag in https://github.com/istio/istio/blob/release-1.0/install/kubernetes/helm/istio/values.yaml#L9

However, these chart files need to use semantic versions so a stable release tag won't work. I don't have an immediate plan how this can be fixed, but I updated the versions in release-1.0 to 1.0.3, in preparation for the new patch release.

gyliu513 commented 6 years ago

I'm good with this solution, thanks @sdake @linsun @hklai

gyliu513 commented 6 years ago

/close

istio-testing commented 6 years ago

@gyliu513: Closing this issue.

In response to [this](https://github.com/istio/istio/issues/8895#issuecomment-423821137): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.