Mismatch between zipkin-to-stackdriver service name and zipkin address in mixer

[rvrignaud]

Is this a BUG or FEATURE REQUEST?: BUG

Did you review istio.io/help and existing issues to identify if this is already solved or being worked on?: Yes

Bug: Y

What Version of Istio and Kubernetes are you using, where did you get Istio from, Installation details

istioctl version
Version: 0.4.0
GitRevision: 24089ea97c8d244493c93b499a666ddf4010b547
GitBranch: 6401744b90b43901b2aa4a8bced33c7bd54ffc13
User: root@cc5c34bbd1ee
GolangVersion: go1.9.1

kubectl version
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.6", GitCommit:"6260bb08c46c31eea6cb538b34a9ceb3e406689c", GitTreeState:"clean", BuildDate:"2017-12-21T06:34:11Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"8+", GitVersion:"v1.8.6-gke.0", GitCommit:"ee9a97661f14ee0b1ca31d6edd30480c89347c79", GitTreeState:"clean", BuildDate:"2018-01-05T03:36:42Z", GoVersion:"go1.8.3b4", Compiler:"gc", Platform:"linux/amd64"}

Is Istio Auth enabled or not ? istio-ca enabled

What happened: Can't use zipkin-to-stackdriver properly with default install configuration files

What you expected to happen: I expect that zipkin-to-stackdriver work without editing kubernetes service file

How to reproduce it: It seems that there is a mismatch between zipkin-to-stackdriver service name as declared here: https://github.com/istio/istio/blob/master/install/kubernetes/templates/istio-mixer.yaml.tmpl#L82

and zipkin-to-stackdriver as declared here: https://github.com/istio/istio/blob/master/install/kubernetes/templates/addons/zipkin-to-stackdriver.yaml.tmpl#L35

Currently default configuration is not working without modifying one of the two file.

If I understand correctly the problem there can only be one "zipkin" service either pointing to zipkin pod or to the zipkin-to-stackdriver pod.

Feature Request: N

[douglas-reid]

@bianpengyuan can you help with this issue?

[saturnism]

ping

[bianpengyuan]

@rvrignaud You need to modify configs in order to report tracing to stackdriver. 'trace_zipkin_url' in mixer config is just used for mixer's own tracing, but not service tracing. Currently service tracing data does not go through mixer, instead service proxy (envoy) reports tracing data directly to the selected tracing system.

If you want to have service tracing in stackdriver, you need to config the zipkin url in istio cofig map (https://goo.gl/BTMhex) to zipkin-to-stackdriver service url, which will be used by proxy when reporting tracing data.

[rvrignaud]

Hi @bianpengyuan,

Thank you for your reply. I think that changing this service name https://github.com/istio/istio/blob/master/install/kubernetes/templates/addons/zipkin-to-stackdriver.yaml.tmpl#L35 zipkin would allow zipkin-to-stackdriver work out of the box. With a warning in the documentation stating that zipkin-to-stackdriver addon installation is mutually exclusive with zipkin or jaeger addon. I think this would be a much better user experience.

You should notice that in our documentation we point to jaeger here : https://istio.io/docs/tasks/telemetry/distributed-tracing.html And jaeger service is using zipkin name as I propose for zipkin-to-stackdriver.

What do you think ?

[kyessenov]

Can something be done in the context of https://github.com/istio/istio/issues/4853?

[bianpengyuan]

@rvrignaud I will add zipkin-to-stackdriver to the tracing doc to reduce confusion.

[douglas-reid]

Can we close this now?

[rvrignaud]

I don't see anymore the zipkin-to-stackdriver addon in install/kubernetes/addons. Not sure if this is still supported