search

istio / old_issues_repo

Deprecated issue-tracking repo, please post new issues or feature requests to istio/istio instead.
37 stars 9 forks source link

Ansible install directory only contains README #223

Open geoand opened 6 years ago

geoand commented 6 years ago

Checking the produced artifacts for releases 0.5.0 and 0.5.1 (both for Linux an OSX), I found that the directory install/ansible contains only the README and none of the playbook files.

I would like to submit a PR to fix this, but since I am not aware of how Istio is built, any pointers would be welcome.

Thank you

geoand commented 6 years ago

This is issue persists in 0.6.0 and 0.7.0.

@sdake Can you please have a look? I would very much like to contribute a fix, but since I'm not very familiar with Go or it's build tools, I don't really know were to look.

Thanks!

sdake commented 6 years ago

@geoand I've been reviewing your work in https://github.com/istio/istio/pull/4623 - however I don't have ACLs to merge the work. @sebastienvas may be able to further help.

Cheers -steve

geoand commented 6 years ago

Thank you very much!

On Mon, Apr 9, 2018, 14:59 Steven Dake notifications@github.com wrote:

@geoand https://github.com/geoand I've been reviewing your work in istio/istio#4623 https://github.com/istio/istio/pull/4623 - however I don't have ACLs to merge the work. @sebastienvas https://github.com/sebastienvas may be able to further help.

Cheers -steve

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/istio/issues/issues/223#issuecomment-379743080, or mute the thread https://github.com/notifications/unsubscribe-auth/AELBv-0Kg_8Q70ISdWsmdQvFODXwJejhks5tm1s1gaJpZM4SPZ10 .

geoand commented 6 years ago

@sebastienvas Do we need to do anything to get this merged?