Improve test coverage of //pkg/runtime

istio / old_mixer_repo

Deprecated home of Istio's Mixer and its adapters, now in istio/istio's mixer dir

https://github.com/istio/istio/tree/master/mixer

Apache License 2.0

67 stars 93 forks source link

Improve test coverage of //pkg/runtime #1298

Open douglas-reid opened 7 years ago

douglas-reid commented 7 years ago

https://codecov.io/gh/istio/mixer/tree/master/pkg/runtime

There are some files in this package that should be fairly easy for which to improve coverage:

env.go
init.go
logger.go
resourceType.go

jmuk commented 7 years ago

Seems to be solved by @mandarjog https://github.com/istio/mixer/pull/1300? I don't know why codecov isn't refreshed yet, but env.go, logger.go, and resourceType.go are now 100% covered. init.go is low, but I think it's by-design.

sakshigoel12 commented 7 years ago

@douglas-reid can you update release milestone