istio / old_mixer_repo

Deprecated home of Istio's Mixer and its adapters, now in istio/istio's mixer dir
https://github.com/istio/istio/tree/master/mixer
Apache License 2.0
67 stars 93 forks source link

Added authorization template #1458

Closed mangchiandjjoe closed 7 years ago

mangchiandjjoe commented 7 years ago

Release note:

Authorization adapter template.
Any authorization module needs to answer the question: Is a “subject” allowed to do an “action”. 

This change is Reviewable

istio-merge-robot commented 7 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: guptasu

Assign the PR to them by writing /assign @guptasu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/istio/mixer/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
codecov[bot] commented 7 years ago

Codecov Report

Merging #1458 into master will increase coverage by <.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1458      +/-   ##
==========================================
+ Coverage   84.65%   84.65%   +<.01%     
==========================================
  Files         122      122              
  Lines       11922    11922              
==========================================
+ Hits        10092    10093       +1     
+ Misses       1634     1633       -1     
  Partials      196      196
Impacted Files Coverage Δ
adapter/stackdriver/metric/bufferedClient.go 90% <0%> (-2.5%) :arrow_down:
tools/codegen/pkg/inventory/generator.go 71.87% <0%> (+6.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b1e720...8b6c32d. Read the comment docs.

mangchiandjjoe commented 7 years ago

@geeknoid @douglas-reid @mandarjog @guptasu @ZackButcher @liminw

Could you please review the PR?

geeknoid commented 7 years ago

I started a conversation about auth templates here: https://groups.google.com/forum/#!topic/istio-integrations/hWPkl95MmHM

Let's discuss there for a while.

Thanks.

geeknoid commented 7 years ago

This repo is no longer accepting PRs. Please resubmit this change to the istio/istio repo.

Thanks.