Closed istio-testing closed 7 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: We suggest the following additional approver: douglas-reid
Assign the PR to them by writing /assign @douglas-reid
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/test all [submit-queue is verifying that this PR is safe to merge]
Merging #1459 into master will increase coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
+ Coverage 84.65% 84.66% +0.01%
==========================================
Files 122 122
Lines 11922 11922
==========================================
+ Hits 10092 10094 +2
+ Misses 1634 1632 -2
Partials 196 196
Impacted Files | Coverage Δ | |
---|---|---|
tools/codegen/pkg/inventory/generator.go | 71.87% <0%> (+6.25%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1b1e720...d8f5505. Read the comment docs.
Automatic merge from submit-queue.
This PR will be merged automatically once checks are successful.
This change is