Closed istio-testing closed 7 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: We suggest the following additional approver: guptasu
Assign the PR to them by writing /assign @guptasu
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/test all [submit-queue is verifying that this PR is safe to merge]
Merging #1468 into master will increase coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1468 +/- ##
==========================================
+ Coverage 84.64% 84.65% +0.01%
==========================================
Files 122 122
Lines 11922 11922
==========================================
+ Hits 10091 10093 +2
+ Misses 1635 1633 -2
Partials 196 196
Impacted Files | Coverage Δ | |
---|---|---|
tools/codegen/pkg/inventory/generator.go | 65.62% <0%> (-6.25%) |
:arrow_down: |
pkg/config/crd/store.go | 96.96% <0%> (+0.6%) |
:arrow_up: |
adapter/prometheus/server.go | 94.91% <0%> (+5.08%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0abf349...1e8ad37. Read the comment docs.
Automatic merge from submit-queue.
This PR will be merged automatically once checks are successful.
This change is