Closed istio-testing closed 7 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: We suggest the following additional approver: zackbutcher
Assign the PR to them by writing /assign @zackbutcher
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/test all [submit-queue is verifying that this PR is safe to merge]
Merging #1486 into master will increase coverage by
0.17%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1486 +/- ##
==========================================
+ Coverage 84.66% 84.84% +0.17%
==========================================
Files 122 122
Lines 11922 12066 +144
==========================================
+ Hits 10094 10237 +143
- Misses 1632 1637 +5
+ Partials 196 192 -4
Impacted Files | Coverage Δ | |
---|---|---|
pkg/expr/func.go | 98.47% <0%> (-0.05%) |
:arrow_down: |
pkg/il/compiler/compiler.go | 89.55% <0%> (+1.35%) |
:arrow_up: |
pkg/il/evaluator/evaluator.go | 87.5% <0%> (+4.71%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4eba741...f84f052. Read the comment docs.
Automatic merge from submit-queue.
This PR will be merged automatically once checks are successful.
This change is